Linker API Changes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
execution
tests
examples
priority-high
priority-medium
priority-low
labels
|
I recommend looking at the first commit and the last. The one in the middle only changes the tests. |
george-cosma
force-pushed
the
dev/api_changes
branch
from
95328ef
to
4820a3b
Compare
Codecov ReportAttention: Patch coverage is
|
nerodesu017
reviewed
Sep 24, 2024
george-cosma
force-pushed
the
dev/api_changes
branch
2 times, most recently
from
fda3926
to
ad23b4c
Compare
george-cosma
force-pushed
the
dev/api_changes
branch
5 times, most recently
from
47111bf
to
8c3b877
Compare
Signed-off-by: George Cosma <[email protected]>
Signed-off-by: George Cosma <[email protected]>
george-cosma
force-pushed
the
dev/api_changes
branch
from
8c3b877
to
7411d43
Compare
florianhartung
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request changes the RuntimeInstance API to be compatible with the #87 linker proposal. The PR follows the proposal highlighted in issue #83, more precisely this comment. This was made to avoid the multitude of functions that would be create when introducing the idea of "modules" and "module_index"
Formatting
cargo fmtcargo checkcargo buildcargo docnix fmtGithub Issue
This pull request helps close #83